feat: add retrieval protocol code parsing #418
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/add-retrieval-protocol-code-parsing
branch
from
d75827f to
9a16acf
Compare
vasco-santos
force-pushed
the
feat/add-retrieval-protocol-code-parsing
branch
from
9a16acf to
e4aa322
Compare
This was referenced May 23, 2025
vasco-santos
force-pushed
the
feat/add-retrieval-protocol-code-parsing
branch
from
04e8a85 to
b921c8c
Compare
|
While multiformats/multicodec#380 is resolved, #425 allows experimententation with new protocols without needing to PR support in here. See Adding custom protocols in the README. |
|
Thanks @achingbrain ! This is great, I don't need to run with a fork for the time being then |
|
I'm going to convert this to a draft for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a retrieval code as draft to hint what kind of retrieval protocols one host may run. e.g.
/ip4/.../p2p/qmfoo/tag/bitswap/tag/httpas discussedThis enables us to be able to prioritize dialling to hosts that we know how to communicate with and avoid unnecessary dials. This is an optional Hint.
More context: https://github.com/vasco-santos/provider-hinted-uri/blob/main/EXPLORATION.md
Multicodec PR ready multiformats/multicodec#380